bugfix/view_ranges #436
Merged
bugfix/view_ranges #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Subtle fix on ordering of the cross-sections on the x-axis. |
rsueppel
reviewed
Jul 19, 2022
macrosynergy/panel/view_ranges.py
Outdated
| if ylab is None: | ||
| ylab = "" | ||
|
|
||
| if sort_cids_by == 'mean': | ||
| dfx = df[df['xcat'] == xcats[0]].groupby(['cid'])[val].mean() | ||
| dfx = dfd.groupby(['cid'])[val].mean() |
There was a problem hiding this comment.
Where does dfd come from? Also, what category's mean is the basis of the order?
The only solution seeems to be to order by first category, as before, but append any other cids that are not in order alphabetically,
rsueppel
approved these changes
Jul 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groupby the union, across categories, of cross-sections.