Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/naive_pnl_neg #462

Merged
merged 3 commits into from
Aug 23, 2022
Merged

feature/naive_pnl_neg #462

merged 3 commits into from
Aug 23, 2022

Conversation

Ksteeds
Copy link
Contributor

@Ksteeds Ksteeds commented Aug 21, 2022

Temporary submission. Awaiting other PR approval: #445.

@Ksteeds Ksteeds requested a review from rsueppel August 21, 2022 16:02
@Ksteeds Ksteeds self-assigned this Aug 21, 2022
@Ksteeds Ksteeds linked an issue Aug 21, 2022 that may be closed by this pull request
@Ksteeds
Copy link
Contributor Author

Ksteeds commented Aug 21, 2022

Known bug and requires Unit Test.

@Ksteeds
Copy link
Contributor Author

Ksteeds commented Aug 22, 2022

Conflict in NaivePnL - required resolving.

@rsueppel rsueppel merged commit a0a3fc3 into develop Aug 23, 2022
@rsueppel rsueppel deleted the feature/naive_pnl_neg branch August 23, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add sig_neg option to make_pnl
2 participants