Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#506 bugfix #518

Merged
merged 4 commits into from
Sep 27, 2022
Merged

#506 bugfix #518

merged 4 commits into from
Sep 27, 2022

Conversation

Magnus167
Copy link
Member

@mikiinterfiore : changing Markdown image reference for Logo as per @Magnus167

changing Markdown image reference for Logo as per @Magnus167
@Magnus167 Magnus167 linked an issue Sep 26, 2022 that may be closed by this pull request
README.md Outdated
@@ -1,4 +1,4 @@
![Macrosynergy](docs/source/_static/MACROSYNERGY_Logo_Primary.png)
![Macrosynergy](https://raw.githubusercontent.com/macrosynergy/macrosynergy/develop/docs/source/_static/MACROSYNERGY_Logo_Primary.png?raw=True)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be the main branch for the URL instead of the develop? Otherwise looks good.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, made the change

Copy link
Member Author

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the source URL for the image from the develop branch to the main branch.

Copy link
Member

@lsimonsen lsimonsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All approved @Magnus167

@CyrusYavariMacro CyrusYavariMacro merged commit 3833c92 into develop Sep 27, 2022
@lsimonsen lsimonsen deleted the bugfix/add_logo_to_pypi_site branch September 29, 2022 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyPI: add logo to site
4 participants