changed "ci" keyword to "estimator" in sns.lineplot calls in view_timelines.py #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "ci" (confidence interval) argument/keyword specifies a method for creating error-bars in lineplots
seaborn(up to and incl. version 11.2).In
seabornversion 12 onwards, this has been deprecated, and replaced by theestimatorkeyword, which allows the user to specify which estimator to use.The implication is that seaborn ignores the argument, and goes on to run error-bar estimation calculations on the data.
It is does not cause a single lineplot to be significantly slower, however when using a panel with multiple lineplots (seaborn.FacetGrid), the output takes much longer.
The issue is documented on the seaborn repository issues here : mwaskom/seaborn#3006
To which the solution (implemented in this commit) is also provided by repo. owner : mwaskom/seaborn#3006 (comment).
The solution is backward compatible and needs to be implemented in other functions of the macrosynergy package that may use "ci" arguments for lineplots. It is compatible down to (and incl.) seaborn version 0.9.0 (July 2018).