Adding feature to publish to TestPyPI #527
Conversation
There was a problem hiding this comment.
@Magnus167 and @mikiinterfiore left a few comments for you. Let me know what you think.
| try: | ||
| from .version import git_revision as __git_revision__ | ||
| from .version import version as __version__ | ||
| except ModuleNotFoundError: | ||
| from setup import get_version_info | ||
| FULLVERSION, GIT_REVISION = get_version_info() | ||
| __version__ = FULLVERSION | ||
| __git_revision__ = GIT_REVISION |
There was a problem hiding this comment.
Given that we added this to the macrosynergy.__init__ we should be able to get it as:
from macrosynergy import __version__| # test for TestPyPI version number | ||
|
|
||
| package = 'macrosynergy' | ||
| with requests.get(f'https://test.pypi.org/pypi/{package}/json') as r: |
There was a problem hiding this comment.
Why not put the package name directly in the URL, so that it becomes with requests.get(f'https://test.pypi.org/pypi/macrosynergy/json') as r:?
setup.py
Outdated
|
|
||
| MICRO = 18 | ||
| ISRELEASED = True | ||
|
|
There was a problem hiding this comment.
Any particular reasons for the blank spaces?
Updated in accordance to inputs from @lsimonsen
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## develop #527 +/- ##
==========================================
Coverage ? 60.35%
==========================================
Files ? 26
Lines ? 2797
Branches ? 0
==========================================
Hits ? 1688
Misses ? 1109
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Adding a feature to publish to TestPyPI using GitHub Actions