Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion for PyPI version checks #556

Merged
merged 3 commits into from
Oct 11, 2022
Merged

Suggestion for PyPI version checks #556

merged 3 commits into from
Oct 11, 2022

Conversation

lsimonsen
Copy link
Member

Suggestion for checking if versions has been updated.

Suggestion of logic:

  1. The version of the package needs to be greater or equal to the one on test.pypi.
  2. For PyPI itself, it needs to always be greater (as the published package is immutable).

What do you think @Magnus167 ?

@lsimonsen lsimonsen added the enhancement New feature or request label Oct 10, 2022
@lsimonsen lsimonsen self-assigned this Oct 10, 2022
Magnus167
Magnus167 previously approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated code reviewed ✔️

Magnus167
Magnus167 approved these changes Oct 11, 2022
View reviewed changes
Copy link
Member

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renamed file

@lsimonsen lsimonsen merged commit 21a538b into develop Oct 11, 2022
@lsimonsen lsimonsen deleted the feature/pypi-version branch October 11, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Magnus167 Magnus167 Magnus167 approved these changes

Assignees

@lsimonsen lsimonsen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lsimonsen @Magnus167