Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated plot_pnls to include facets argument #557

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

Magnus167
Copy link
Member

The default behaviour for the plot_pnls function was to output a single graph. In v0.0.18 this was changed to output a FacetGrid. Now been changed to output a single graph, but can output a facetgrid on request.

@codecov-commenter
Copy link

Codecov Report

Base: 60.22% // Head: 60.07% // Decreases project coverage by -0.15% ⚠️

Coverage data is based on head (622c3a1) compared to base (9d26565).
Patch coverage: 0.00% of modified lines in pull request are covered.

❗ Current head 622c3a1 differs from pull request most recent head 056bd2f. Consider uploading reports for the commit 056bd2f to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #557      +/-   ##
===========================================
- Coverage    60.22%   60.07%   -0.16%     
===========================================
  Files           26       26              
  Lines         2803     2810       +7     
===========================================
  Hits          1688     1688              
- Misses        1115     1122       +7     
Impacted Files Coverage Δ
macrosynergy/pnl/naive_pnl.py 57.87% <0.00%> (-1.34%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rsueppel rsueppel merged commit 70e115f into develop Oct 10, 2022
@lsimonsen lsimonsen deleted the bugfix/naive_pnl_facet_argument branch October 11, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants