Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix/pnl_refactor #570

Merged
merged 3 commits into from
Oct 12, 2022
Merged

bugfix/pnl_refactor #570

merged 3 commits into from
Oct 12, 2022

Conversation

Ksteeds
Copy link
Contributor

@Ksteeds Ksteeds commented Oct 11, 2022

FacetGrid bug.

@Ksteeds Ksteeds requested a review from rsueppel October 11, 2022 10:38
@Ksteeds Ksteeds self-assigned this Oct 11, 2022
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Base: 60.02% // Head: 60.60% // Increases project coverage by +0.58% 🎉

Coverage data is based on head (7e62a79) compared to base (62b2a28).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #570      +/-   ##
===========================================
+ Coverage    60.02%   60.60%   +0.58%     
===========================================
  Files           26       26              
  Lines         2809     2810       +1     
===========================================
+ Hits          1686     1703      +17     
+ Misses        1123     1107      -16     
Impacted Files Coverage Δ
macrosynergy/management/shape_dfs.py 98.48% <ø> (ø)
macrosynergy/pnl/naive_pnl.py 57.69% <0.00%> (-0.19%) ⬇️
macrosynergy/signal/target_positions.py 9.34% <0.00%> (+9.34%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ksteeds
Copy link
Contributor Author

Ksteeds commented Oct 11, 2022

Failing because of inadvertent package update.

@Ksteeds Ksteeds merged commit 1e0b466 into develop Oct 12, 2022
@Magnus167 Magnus167 deleted the bugfix/pnl_refactor branch November 15, 2022 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants