Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ralph adds just one letter #590

Merged
merged 4 commits into from
Nov 3, 2022
Merged

Ralph adds just one letter #590

merged 4 commits into from
Nov 3, 2022

Conversation

rsueppel
Copy link
Contributor

@rsueppel rsueppel commented Nov 2, 2022

No description provided.

@codecov-commenter
Copy link

Codecov Report

Base: 60.60% // Head: 60.60% // No change to project coverage 👍

Coverage data is based on head (78584ec) compared to base (71578b6).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #590   +/-   ##
========================================
  Coverage    60.60%   60.60%           
========================================
  Files           26       26           
  Lines         2810     2810           
========================================
  Hits          1703     1703           
  Misses        1107     1107           
Impacted Files Coverage Δ
macrosynergy/management/shape_dfs.py 98.48% <ø> (ø)
macrosynergy/panel/historic_vol.py 94.59% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Magnus167
Magnus167 previously approved these changes Nov 3, 2022
Copy link
Member

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One letter changed. (and some whitespace)

Copy link
Member

@Magnus167 Magnus167 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One letter, and one digit changed.

  • Change in ms.pnl.historic_vol() docstring
  • Change in setup.py version number

@Magnus167 Magnus167 merged commit c200bbd into develop Nov 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants