Bugfix in business_day_dif #620
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 59.11% // Head: 59.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #620 +/- ##
===========================================
- Coverage 59.11% 59.09% -0.03%
===========================================
Files 28 28
Lines 2950 2948 -2
===========================================
- Hits 1744 1742 -2
Misses 1206 1206
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Ksteeds
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Python Datetime's/Pandas'
isocalender()represents a date in the form (Year, Week number, Week day). One of the calculations was using an a deprecated form of getting the year for the calculations. Updating the code to usepd.DatetimeIndex.isocalender()fixed the issue. Important point to remember is that theisocalender()functionality must NOT be confused withisoformat().