Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix : Changed internal date formatting #689

Merged
merged 3 commits into from
Mar 8, 2023

Conversation

Magnus167
Copy link
Member

DQ formatting specifies using YYYYMMDD as a date format, while the ISO (8601) format is YYYY-MM-DD. The package now explicitly removes the dashes while type checking to ensure the date is formatted as per DQ documentation.

@Magnus167 Magnus167 requested a review from lsimonsen March 7, 2023 10:15
@codecov-commenter
Copy link

codecov-commenter commented Mar 7, 2023

Codecov Report

Patch coverage: 9.09% and project coverage change: -0.17 ⚠️

Comparison is base (b842ed2) 61.37% compared to head (b77be4e) 61.20%.

❗ Current head b77be4e differs from pull request most recent head 4bab05b. Consider uploading reports for the commit 4bab05b to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #689      +/-   ##
===========================================
- Coverage    61.37%   61.20%   -0.17%     
===========================================
  Files           29       29              
  Lines         3135     3145      +10     
===========================================
+ Hits          1924     1925       +1     
- Misses        1211     1220       +9     
Impacted Files Coverage Δ
macrosynergy/download/dataquery.py 32.76% <0.00%> (-0.12%) ⬇️
macrosynergy/download/jpmaqs.py 51.11% <11.11%> (-1.40%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Magnus167 Magnus167 changed the title changed internal datetime formatting Bugfix : Changed internal date formatting Mar 7, 2023
@Magnus167 Magnus167 merged commit 2ade6de into develop Mar 8, 2023
@Magnus167 Magnus167 deleted the bugfix/update_dq_date_formats branch March 9, 2023 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants