Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix : corrected exception handling in retry routine #691

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

Magnus167
Copy link
Member

Exception handling code was added to allow retrying downloads (up to 5 times) before failing.
The earlier code handled all exceptions and caused retries for exceptions that require the code to break eg. AuthenticationError

@codecov-commenter
Copy link

Codecov Report

Patch coverage has no change and project coverage change: -0.08 ⚠️

Comparison is base (b842ed2) 61.37% compared to head (f130614) 61.29%.

❗ Current head f130614 differs from pull request most recent head 2961211. Consider uploading reports for the commit 2961211 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #691      +/-   ##
===========================================
- Coverage    61.37%   61.29%   -0.08%     
===========================================
  Files           29       29              
  Lines         3135     3139       +4     
===========================================
  Hits          1924     1924              
- Misses        1211     1215       +4     
Impacted Files Coverage Δ
macrosynergy/download/dataquery.py 32.43% <0.00%> (-0.45%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Magnus167 Magnus167 merged commit 05ba401 into develop Mar 8, 2023
@Magnus167 Magnus167 deleted the bugfix/api_unbound_error_2 branch March 8, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants