Bugfix: test_package.py, Failing on Windows systems
#794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magnus167
changed the title
test_package.py, Fails on Windows systems with spaces in pathtest_package.py, Failing on Windows systems
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #794 +/- ##
========================================
Coverage 71.30% 71.30%
========================================
Files 31 31
Lines 3666 3666
========================================
Hits 2614 2614
Misses 1052 1052 ☔ View full report in Codecov by Sentry. |
lsimonsen
reviewed
May 12, 2023
| @@ -9,15 +9,15 @@ def test_lazy_imports(self): | |||
| cmd = ("import macrosynergy as msy; " | |||
| "import sys; ") | |||
|
|
|||
| cmd = sys.executable + ' -c "' + cmd + '"' | |||
| cmd = f'"{sys.executable}" -c "' + cmd + '"' | |||
| p = subprocess.Popen(cmd, shell=True, close_fds=True) | |||
There was a problem hiding this comment.
Why not run it as:
p = subprocess.Popen([sys.executable, "-c", cmd], shell=True, close_fds=True)
lsimonsen
approved these changes
May 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fails on a Windows system where the user may have a space such as
C:/User Name/script.py