Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix : Unittest/API #805

Merged
merged 3 commits into from
May 17, 2023
Merged

Bugfix : Unittest/API #805

merged 3 commits into from
May 17, 2023

Conversation

Magnus167
Copy link
Member

The unittests for the API made use of actual API calls. This is conceptually wrong, and ideally unittests should be constructed to mock every external variable, except for the function being tested. This PR corrects the current implementation

@codecov
Copy link

codecov bot commented May 16, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.78 ⚠️

Comparison is base (d71ef87) 75.48% compared to head (66a1d61) 73.71%.

❗ Current head 66a1d61 differs from pull request most recent head db3b935. Consider uploading reports for the commit db3b935 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #805      +/-   ##
===========================================
- Coverage    75.48%   73.71%   -1.78%     
===========================================
  Files           31       31              
  Lines         3667     3667              
===========================================
- Hits          2768     2703      -65     
- Misses         899      964      +65     

see 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Magnus167 Magnus167 merged commit 7015407 into develop May 17, 2023
6 checks passed
@Magnus167 Magnus167 deleted the bugfix/api_unittests branch May 17, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants