Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: view_timelines - Title-fontsize and Title-X-Pos adjustment #817

Merged
merged 1 commit into from
May 18, 2023

Conversation

Magnus167
Copy link
Member

@Magnus167 Magnus167 commented May 18, 2023

Added a feature to adjust the font-size and the x-position of the title of a view_timelines plot.
Docstring:

"""
:param <float> title_xadj: parameter that sets x position of title. Default is 0.5.
:param <int> title_fontsize: font size of title. Default is 16.
"""

This also hints that either:
[1] All visual functions must include an x_adj and y_adj;
[2] Or they must support the use of an X-Y tuple as the _adj variable

@Magnus167 Magnus167 requested a review from rsueppel May 18, 2023 11:26
@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (d129d0e) 73.74% compared to head (8038e31) 73.74%.

❗ Current head 8038e31 differs from pull request most recent head 8cd3cec. Consider uploading reports for the commit 8cd3cec to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #817   +/-   ##
========================================
  Coverage    73.74%   73.74%           
========================================
  Files           31       31           
  Lines         3671     3671           
========================================
  Hits          2707     2707           
  Misses         964      964           
Impacted Files Coverage Δ
macrosynergy/panel/view_timelines.py 91.07% <75.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rsueppel rsueppel merged commit 5894a36 into develop May 18, 2023
6 checks passed
@Magnus167 Magnus167 deleted the feature/title_adjs_vt branch May 23, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants