Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix : Removing vweights_threshold param from linear_composites #850

Merged
merged 6 commits into from
Jun 2, 2023

Conversation

Magnus167
Copy link
Member

The argument was not needed and was partially in conflict with the specified docstring in #823

@Magnus167 Magnus167 requested a review from rsueppel June 2, 2023 15:14
@codecov
Copy link

codecov bot commented Jun 2, 2023

Codecov Report

Patch coverage: 65.21% and project coverage change: +0.01 🎉

Comparison is base (555bb9f) 73.65% compared to head (ed4af8b) 73.67%.

❗ Current head ed4af8b differs from pull request most recent head c812681. Consider uploading reports for the commit c812681 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #850      +/-   ##
===========================================
+ Coverage    73.65%   73.67%   +0.01%     
===========================================
  Files           31       31              
  Lines         3792     3787       -5     
===========================================
- Hits          2793     2790       -3     
+ Misses         999      997       -2     
Impacted Files Coverage Δ
macrosynergy/download/dataquery.py 71.77% <33.33%> (-0.71%) ⬇️
macrosynergy/management/check_availability.py 47.54% <33.33%> (+0.98%) ⬆️
macrosynergy/panel/linear_composite.py 73.55% <100.00%> (+0.27%) ⬆️
macrosynergy/panel/view_timelines.py 91.66% <100.00%> (+0.59%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rsueppel rsueppel merged commit 6ebd7b8 into develop Jun 2, 2023
6 checks passed
@Magnus167 Magnus167 deleted the bugfix/lcomp_vthresh branch June 28, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants