Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: Updating docstring for linear_composite() #880

Merged
merged 2 commits into from
Jul 4, 2023

Conversation

Magnus167
Copy link
Member

No description provided.

@Magnus167 Magnus167 requested a review from rsueppel July 4, 2023 12:02
@codecov
Copy link

codecov bot commented Jul 4, 2023

Codecov Report

Patch coverage: 18.18% and project coverage change: -0.04 ⚠️

Comparison is base (8d6de57) 73.56% compared to head (6f95a26) 73.52%.

❗ Current head 6f95a26 differs from pull request most recent head 33ac529. Consider uploading reports for the commit 33ac529 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #880      +/-   ##
===========================================
- Coverage    73.56%   73.52%   -0.04%     
===========================================
  Files           31       31              
  Lines         3802     3804       +2     
===========================================
  Hits          2797     2797              
- Misses        1005     1007       +2     
Impacted Files Coverage Δ
macrosynergy/panel/linear_composite.py 73.55% <0.00%> (ø)
macrosynergy/management/check_availability.py 46.03% <20.00%> (-1.51%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@rsueppel rsueppel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add to signs docstring: "Default is positive signs only".

@rsueppel rsueppel merged commit 8b2bc60 into develop Jul 4, 2023
3 checks passed
@Magnus167 Magnus167 deleted the feature/linear_composite_docs branch July 4, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants