Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: linear_composite(), added pass-through for normalize_weights arg #890

Merged
merged 4 commits into from
Jul 7, 2023

Conversation

Magnus167
Copy link
Member

Modifies default behaviour

Currently the underlying functions linear_composite_on_xcat() & linear_composite_on_cid() have arguments for normalize_weights. However, the call to these functions had the flag hardcoded. This arg has now been added to the wrapper, with a pass-through.
Another bugfix - some arguments are modified before being passed to the backend. There is a .copy() to prevent modifying them outside the current scope.

@Magnus167 Magnus167 requested a review from rsueppel July 6, 2023 16:21
rsueppel
rsueppel previously approved these changes Jul 6, 2023
@codecov
Copy link

codecov bot commented Jul 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.03 🎉

Comparison is base (13506d7) 73.52% compared to head (8d41321) 73.56%.

❗ Current head 8d41321 differs from pull request most recent head cd8acc6. Consider uploading reports for the commit cd8acc6 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #890      +/-   ##
===========================================
+ Coverage    73.52%   73.56%   +0.03%     
===========================================
  Files           31       31              
  Lines         3804     3809       +5     
===========================================
+ Hits          2797     2802       +5     
  Misses        1007     1007              
Impacted Files Coverage Δ
macrosynergy/panel/linear_composite.py 74.60% <100.00%> (+1.04%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rsueppel rsueppel merged commit ab4fd9e into develop Jul 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants