Bugfix: linear_composite()
, added pass-through for normalize_weights
arg
#890
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies default behaviour
Currently the underlying functions
linear_composite_on_xcat()
&linear_composite_on_cid()
have arguments fornormalize_weights
. However, the call to these functions had the flag hardcoded. This arg has now been added to the wrapper, with a pass-through.Another bugfix - some arguments are modified before being passed to the backend. There is a
.copy()
to prevent modifying them outside the current scope.