Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: SignalReturnRelations.apply_slip() to raise warning instead of error for missing tickers #904

Merged
merged 2 commits into from
Jul 26, 2023

Conversation

Magnus167
Copy link
Member

No description provided.

@Magnus167 Magnus167 linked an issue Jul 26, 2023 that may be closed by this pull request
@Magnus167 Magnus167 requested a review from rsueppel July 26, 2023 10:18
@Magnus167 Magnus167 changed the title bugfix for #902 Bugfix: SignalReturnRelations.apply_slip() to raise warning instead of error for missing tickers Jul 26, 2023
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (fa053fe) 74.47% compared to head (d17636b) 74.47%.

❗ Current head d17636b differs from pull request most recent head cd0c335. Consider uploading reports for the commit cd0c335 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #904   +/-   ##
========================================
  Coverage    74.47%   74.47%           
========================================
  Files           31       31           
  Lines         3827     3828    +1     
========================================
+ Hits          2850     2851    +1     
  Misses         977      977           
Files Changed Coverage Δ
macrosynergy/signal/signal_return.py 73.19% <100.00%> (+0.11%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rsueppel rsueppel merged commit 9fe120e into develop Jul 26, 2023
3 checks passed
@Magnus167 Magnus167 deleted the bugfix/srr_cid_error_902 branch July 27, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SignalReturnRelations cannot handle missing cross sections
2 participants