Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds code intention comments and TODOs #925

Merged

Conversation

rsueppel
Copy link
Contributor

In think I understood most of the code, but am not 100% sure.
This has a number of the TODOs, but only a few major ones.

  • The repetive code parts should be combined.
  • Split dates and sample start dates should be clearer disentangled.

The minimum logic of interval learning must work as follows:

The first valid training sample must satisfy both min_cids and min_periods conditions.
However, the start date can be before the first date for which min_cids is satisfied,
We do not want to waste the experiences of countries with long history.
The max_periods condition may apply.

Please add a little commentary to explain the intentions of code sections
Also always inform about what methods return with return keyword.

@rushilg99 rushilg99 merged commit 2049dd2 into feature/panel_splitter_class Aug 21, 2023
@Magnus167 Magnus167 deleted the feature/panel_splitter_class_rs branch September 14, 2023 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants