adds code intention comments and TODOs #925
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In think I understood most of the code, but am not 100% sure.
This has a number of the TODOs, but only a few major ones.
The minimum logic of interval learning must work as follows:
The first valid training sample must satisfy both min_cids and min_periods conditions.
However, the start date can be before the first date for which min_cids is satisfied,
We do not want to waste the experiences of countries with long history.
The max_periods condition may apply.
Please add a little commentary to explain the intentions of code sections
Also always inform about what methods return with return keyword.