Bugfix: panel_calculator(), error with CID-XCAT intersection
#968
Conversation
Magnus167
changed the title
panel_calculator(), error with incomplete CID-XCAT intersectionpanel_calculator(), error with CID-XCAT intersection
|
|
||
| if len(singles_used) > 0: | ||
| if new_xcats == all_xcats_used: | ||
| old_xcats_used: List[str] = new_xcats |
There was a problem hiding this comment.
It seems that the intention is to prevent an undue data frame reduction in cases where only new xcats are used.
However, why would be ever want to drop the panel dimensions as defined by cids? Why would that be necessary?
Even if we just pass the string: "XCAT1 = 1" for cids = cidx, it should still calculate a panel of 1s.
There was a problem hiding this comment.
A few lines above 165,
old_xcats_used = list(set(all_xcats_used) - set(new_xcats))
...
# after line 167
reduce_df(xcats=old_xcats_used,...)In case where an XCAT does not exist for a particular CID, it will be in new_xcats as well as all_xcats_used.
With context to the example in #967:
formula = "RIR_NSA = iEUR_RIR_NSA"implying
all_xcats_used == new_xcats;
and therefore
old_xcats_used == []
Re. enhancement for allowing numerical assignment:
As of now, the example "XCAT = 1" will not work with the panel calculator. There are multiple steps at which an operation like this would fail. This would be better solved as an enhancement
Closes issue #967