Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy stuff #173

Closed
splhack opened this issue Dec 15, 2015 · 8 comments
Closed

Remove legacy stuff #173

splhack opened this issue Dec 15, 2015 · 8 comments

Comments

@splhack
Copy link
Contributor

splhack commented Dec 15, 2015

No one maintains MacVim_legacy.xcodeproj and PSMTabBarControl_legacy.xcodeproj. It seems no one builds MacVim on OS X 10.6 or earlier. So we can remove these and also 10.4, 10.5 and 10.6 stuff from the code, for example, MMAtsuiTextView.m.

I'll create macvim-dev/macvim-tiger or whatever if anyone wants to maintain MacVim for 10.4, 10.5 and 10.6. Please let me know.

@chdiza
Copy link
Contributor

chdiza commented Dec 15, 2015

Just don't remove the non-native fullscreen mode. It really has nothing to do with Tiger/Leopard/Snow, except indirectly. (It is the only kind of fullscreen mode that can be used on Tiger/Leopard/Snow). It works beautifully on all newer OS versions. It is also superior to native fullscreen mode in almost every respect.

@splhack
Copy link
Contributor Author

splhack commented Dec 15, 2015

I know and will fix #7.

splhack added a commit that referenced this issue Dec 19, 2015
@raimue
Copy link

raimue commented Dec 25, 2015

For MacPorts, we received one report of build errors on OS X 10.6. At least there still seem to be users around, but it does not even build in the current snapshot release.

@splhack
Copy link
Contributor Author

splhack commented Dec 25, 2015

I'll merge #178 soon anyway. I'll create macvim-dev/macvim-tiger or whatever if anyone wants to maintain MacVim for 10.4, 10.5 and 10.6. Please let me know.

@rhendric
Copy link
Contributor

Hi, 10.6 user here (the last snapshot build I can compile as-is is 80). I found this thread while trying to restore 10.6 support to a more recent build; there are probably plenty more qualified people to be maintainers of a legacy branch but I'd like to help.

@splhack
Copy link
Contributor Author

splhack commented Dec 27, 2015

@rhendric the first thing, could you create a pull request for updating MacVim_legacy.xcodeproj and PSMTabBarControl_legacy.xcodeproj? I don't merge #178 if you maintain pre-10.7 code actively in the master branch.

@rhendric
Copy link
Contributor

Are the legacy xcodeprojs for 10.6? My reading is that they're only for 10.4 and 10.5, which I can't test.

A 10.6 build based on snapshot 88 appears very achievable with a minimum of edits/conditionals, by the way. The biggest issue is the new qlstephen subproject, which I just dropped altogether. If MacVim_legacy.xcodeproj becomes for 10.6 instead of for 10.4 and 10.5, then that's easily addressed; otherwise, it's the only change I'm not sure how to package up for a PR.

@splhack
Copy link
Contributor Author

splhack commented Dec 27, 2015

No one wants to maintain 10.4 and 10.5. I'll remove 10.4 and 10.5 stuff and _legacy.xcodeproj.

splhack added a commit that referenced this issue Dec 27, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants