Wrong highlighting in visual mode after latest update

[antaed]

I have set guifg=NONE for the Visual highlighting group in my colorscheme but it gets overridden after the latest update:

[eirnym]

@antaed Thank you for an issue,

Could you share your color scheme to test with?

[antaed]

Of course:
antaed.vim.zip

[eirnym]

Thank you,

guifg/guibg is taken from Normal if it is NONE and visual fg/bg override syntax fg/bg respectively.

Could you tell me what effect you want to achieve?

[antaed]

I would like to have only the background highlighted in visual mode and preserve the syntax highlighting on the foreground, like this:

(the screenshot above was taken on my Windows machine, the color scheme is exactly the same)

[eirnym]

ViM in Terminal has the same issue and MacVim only paints that Vim said to paint.

You should report this issue to the upstream https://github.com/vim/vim as this issue definitely belongs there.

Sorry for misunderstanding on the beginning.

[antaed]

All right, I'll report the issue there. Thank you very much for your support, closing this right now.

[eirnym]

Please, report here the ticket url for tracking

[antaed]

Ok, I'll be back with the url. Do you happen to know which patch created the issue? It must be a very recent one as it worked fine until today.

[eirnym]

I have snapshot 159, and have the same problem as you. Thank you for reporting!

[eirnym]

@antaed the issue was fixed in the upstream, I hope it will be in snapshot 160, as many things were broken accidentally as I see in other issues there.

[antaed]

That was very quick, you're awesome. Thank you so much!

[ychin]

@eirnym What other issues are you looking to be fixed upstream?

[antaed]

Honestly, I haven't found any other issues besides this one. Thanks for asking

[eirnym]

@ychin as far as I see, other issues were fixed. It even could be built with Python 3.8 (tested it locally)