Fix non-Core Text renderer not working well with wide text #1297
+17
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eirnym
approved these changes
Sep 28, 2022
This was previously broken by macvim-dev#1287 as I did not update the new constants' values. Also, make strikethrough work in it. The non-CoreText renderer is essentially deprecated and will be removed in near future, but for now just fix up the straggling bugs since this is easy to do so. Fix macvim-dev#1296
ychin
force-pushed
the
fix-non-core-text-renderer-strikethrough
branch
from
a474cb2
to
b52f01d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was previously broken by #1287 as I did not update the new constants' values.
Also, make strikethrough work in it.
The non-CoreText renderer is essentially deprecated and will be removed in near future, but for now just fix up the straggling bugs since this is easy to do so.
Fix #1296