Add File.Close support for terminal which also makes it work for Cmd-W #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Vim upstream added support for
:confirm q
for terminals, we can now get our File.Close menu to work properly for them as well. This also means Cmd-W (which is bound to that menu item) works too.Also just add validateMenuItem: for MMAppController even if we are just returning YES. This makes it semantically clearer and is easier to debug.