Fix CI #832
Merged
Fix CI #832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
build error in if_ruby.c:
```
if_ruby.c:1069:9: error: use of unknown builtin '__builtin_alloca_with_align' [-Wimplicit-function-declaration]
buff = ALLOCA_N(char, RSTRING_LEN(str) + 1);
^
/usr/local/Cellar/ruby/2.6.0/include/ruby-2.6.0/ruby/ruby.h:1666:12: note: expanded from macro 'ALLOCA_N'
(type*)__builtin_alloca_with_align((sizeof(type)*(n)), \
^
if_ruby.c:1069:9: warning: cast to 'char *' from smaller integer type 'int' [-Wint-to-pointer-cast]
/usr/local/Cellar/ruby/2.6.0/include/ruby-2.6.0/ruby/ruby.h:1666:5: note: expanded from macro 'ALLOCA_N'
(type*)__builtin_alloca_with_align((sizeof(type)*(n)), \
^
```
Homebrew's ruby bottle for sierra has built by Xcode 9.x, which supports
'__builtin_alloca_with_align' so 'ALLOCA_N' macro in ruby.h uses it, but
Xcode 8.x doesn't support it then causes the above error.
For workaround, should reinstall ruby from source in xcode8.3.
|
Thanks. I have been meaning to look into this. Will merge this in once it passes Travis. It's unfortunate we have to do this though. |
ichizok
pushed a commit
to ichizok/macvim
that referenced
this pull request
Jan 18, 2019
Problem: argv() and argc() only work on the current argument list. Solution: Add a window ID argument. (Yegappan Lakshmanan, closes macvim-dev#832)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build error in if_ruby.c:
Homebrew's ruby bottle for sierra has built by Xcode 9.x, which supports '__builtin_alloca_with_align' so 'ALLOCA_N' macro in ruby.h uses it, but Xcode 8.x doesn't support it then causes the above error.
For workaround, should reinstall ruby from source in xcode8.3.