Fix potential CoreText font rendering infinite recursion #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The function `recurseDraw` is actually a misnomer. It uses recursion in a way that is unnecessary as it's a simple while loop that keeps drawing as many characters as possible until all are drawn. The recursion is just a convenience to invoke the CoreText rendering code. If the API for `CTFontGetGlyphsForCharacters` works as expected, in theory we shouldn't get infinite recursion since `lookupFont` calls the same function, but just for safety and to avoid potential subtle interactions, just kill the recursion and directly draw the texts in the loop to make it easier to reason through. Fix macvim-dev#983.
ychin
force-pushed
the
fix-recurse-draw
branch
from
4237cc8
to
61c8fa4
Compare
ychin
added a commit
that referenced
this pull request
Mar 3, 2020
Vim patch 8.2.319 General: - MacVim is now upgraded to Vim 8.2! Fixes: - Fix mvim:// protocol handler to handle spaces in file names. #1002 - Allow the fullscreen toggle on the Touch Bar to be disabled. #997 - Fixed potential infinite recursion draw crash. #985 Targets macOS 10.9+ Script interfaces have compatibility with these versions: - Lua 5.3 - Perl 5.18 - Python2 2.7 - Python3 3.7 - Ruby 2.7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function
recurseDrawis actually a misnomer. It uses recursion in a way that is unnecessary as it's a simple while loop that keeps drawing as many characters as possible until all are drawn. The recursion is just a convenience to invoke the CoreText rendering code. If the API forCTFontGetGlyphsForCharactersworks as expected, in theory we shouldn't get infinite recursion sincelookupFontcalls the same function, but just for safety and to avoid potential subtle interactions with the API, just kill the recursion and directly draw the texts in the loop to make it easier to reason through.Fix #983.