Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FOV in deg instead of rad. #3

Open
antoinefalisse opened this issue Apr 28, 2021 · 1 comment
Open

FOV in deg instead of rad. #3

antoinefalisse opened this issue Apr 28, 2021 · 1 comment

Comments

@antoinefalisse
Copy link

Hi,

It is not an issue per se, but I think the FOV set here is in degrees, whereas glm::perspective expects a FOV in radian here. Interestingly, it does not have a huge effect on the rendering. Yet the values of the projection matrix P are wrong should anyone would like to use them. Thought that could be useful.

Best,
Antoine
@antoinefalisse antoinefalisse changed the title FOV in deg FOV in deg instead of rad. Apr 28, 2021
@MarliesNit
Copy link
Contributor

Hi,

thanks for pointing this out. Seems that there has been a change on how glm expects the FOV over the versions of glm: read more

This should be updated in the code.

Best,
Marlies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarliesNit @antoinefalisse