Offset by one error #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the radar images need to be offset by 1 minute. Otherwise you end up with a black gif.
|
Hi @kuchel77 -- I'll try to make some time over the next few days to test this out. Thank you for the contribution! |
|
I see what you mean. I'm going to merge this now, but may rework the fix slightly in this repo before releasing a new version to PyPI and opening a PR in HA. It's unfortunate that any of this might break at any moment if BOM changes things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the radar images need to be offset by 1 minute. Otherwise you end up with a black gif. This sets up a list of those stations that are off by 1, and adjusts it so that they now work. It also have a python file that can download all the files so that it can check if it is working. There are a couple of radars that are unavailable at the moment, so I haven't tested with them. There is also still 1 that crashes it.
This should then fix home-assistant/core#23432 as this is what was happening to produce black gifs for that location.