Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change authentication method for cloudwatch datasource #344

Merged
merged 2 commits into from
Oct 31, 2023
Merged

fix: change authentication method for cloudwatch datasource #344

merged 2 commits into from
Oct 31, 2023

Conversation

vitaliimd
Copy link
Contributor

PR Description

To use the outside role, you must use the aws sdk. This method is used by default.

Fixes # (#343)

Type of change

Delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@mglotov mglotov requested a review from a team October 31, 2023 05:25
@sonarcloud
Copy link

sonarcloud bot commented Oct 31, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@vitaliimd vitaliimd merged commit bb70b6c into main Oct 31, 2023
11 checks passed
@vitaliimd vitaliimd deleted the fix/cloudwatch-datasource branch October 31, 2023 05:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mglotov mglotov mglotov approved these changes

@and-babkin and-babkin and-babkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vitaliimd @mglotov @and-babkin