Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test for SelectStandupByChannelID #59

Closed
malikim opened this issue Feb 15, 2018 · 1 comment
Closed

Add test for SelectStandupByChannelID #59

malikim opened this issue Feb 15, 2018 · 1 comment
Assignees
@anatoliyfedorenko

Comments

@malikim
Copy link
Contributor

malikim commented Feb 15, 2018

No description provided.

@malikim malikim self-assigned this Feb 15, 2018
@malikim malikim mentioned this issue Feb 15, 2018
Closed
malikim added a commit that referenced this issue Feb 16, 2018
@malikim
#61 added method SelectStandupByChannelID, #59 added test for SelectS…
60ad645 
…tandupByChannelID, #60 added test for SelectStandupByMessageTS
malikim added a commit that referenced this issue Feb 16, 2018
@malikim
#61 fixed method SelectStandupByChannelID, #59 fixed test for SelectS…
be3d642 
…tandupByChannelID, #60 fixed test for SelectStandupByMessageTS
@anatoliyfedorenko
Copy link
Contributor

implemented in https://github.com/maddevsio/comedian/blob/master/storage/mysql_test.go

selectedByChannelID, err = db.SelectStandupByChannelID(s.ChannelID)
assert.NoError(t, err)
assert.Equal(t, s.Comment, selectedByChannelID[0].Comment)
assert.Equal(t, s.Username, selectedByChannelID[0].Username)

BUT wtf ... i do not understand why SelectStandupByChannelID should return only one standup ... since there should be many standups returned from one channel.

@gen1us2k can you please tell me if i should reimplement this test and therefore the function so that it returns proper results? Seems like it is a bug...

anatoliyfedorenko added a commit that referenced this issue Jul 1, 2018
@anatoliyfedorenko
[#59] Rename SelectStandupByChannelID method
ff3e1c4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anatoliyfedorenko anatoliyfedorenko

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anatoliyfedorenko @malikim