Added protocol support for newer dash buttons. Added documentation for Raspberry Pi #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Added a debug option for testing button presses. Minor documentation updates.
Added details for getting started on Raspberry Pi. Tested on Raspberry Pi 2 running Pixel w/ multiple refreshes to simulate a fresh install.
Formatting and spelling.
More formatting and unsurprisingly more spelling.
Updated with Protip about Wifi. I wish I had thought to try ethernet sooner as it is much more reliable.
Added ability to count button presses for debug purposes.
Merged in Pull request 36
AceoStar
changed the title
|
@maddox Can you approve this? Works pretty well and is quite stable... |
|
There's conflicts on this branch. @AceoStar can you get them resolved? I'll merge it after. |
|
I think that should do it. |
|
@maddox Let me know if you need anything else. Thanks a bunch! |
|
Thank you! |
lorenzos
added a commit
to lorenzos/dasher
that referenced
this pull request
Feb 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all.
The biggest change here is adding support for manually specifying the listener protocol. This is useful for working with the newer JK29LP button. I also added a few other minor helpers for getting noobs like myself moving in the right direction such as a debug option that skips the request and some handling in case you have an undefined response due to misconfiguration. I also updated the documentation to reflect some of the updates seen via the node-dash-button library.
I hope it helps!