Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose bitrate, encoder, and other params in config #62

Closed
mjigmond opened this issue Oct 25, 2016 · 4 comments · Fixed by #63
Closed

Expose bitrate, encoder, and other params in config #62

mjigmond opened this issue Oct 25, 2016 · 4 comments · Fixed by #63

Comments

@mjigmond
Copy link

This is a suggestion for a future enhancement. I am using the graphics accelerated ffmpeg which uses a different video codec, h264_qsv instead of libx264. I'm also using wallop in conjunction with Roku-HDHomeRun and the quality seems to default to 3000k, but I would like it higher (ideal for hardwired connections). I also like to copy the audio as is instead of defaulting to 2 channel AAC. Thanks.

@maddox
Copy link
Owner

maddox commented Oct 26, 2016

Bitrate is configurable already. It's probably being hard coded in Roku-HDHomeRun.

As for the video codec and audio codec stuff, that's fair. I'll look into it.

@maddox
Copy link
Owner

maddox commented Oct 26, 2016

Check out #63. Pull down that branch and give it a try. Warning, I didn't even try it, as I don't really run Wallop anymore, so I don't have it set up, heh.

@mjigmond
Copy link
Author

It works great, thanks! I'll see if @computmaxer is willing to modify the channel to expose quality settings. Otherwise I'll follow the example in your code changes to expose the bitrate in config.

@maddox
Copy link
Owner

maddox commented Oct 27, 2016

I'll just merge this and you can use the regular checkout.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants