Skip to content
This repository has been archived by the owner on Mar 16, 2020. It is now read-only.

fix subpackages imports #292

Closed
wants to merge 1 commit into from
Closed

fix subpackages imports #292

wants to merge 1 commit into from

Conversation

ivaxer
Copy link

@ivaxer ivaxer commented Mar 5, 2014

Fix go app get error:

➜  ~GOPATH  goapp get -d  github.com/mjibson/goread
package atom: unrecognized import path "atom"
package rdf: unrecognized import path "rdf"
package rss: unrecognized import path "rss"
package sanitizer: unrecognized import path "sanitiser"

@maddyblue
Copy link
Owner

I'm not sure the current method is wrong. It's just the importer complaining that it can't find them. But consider the "appengine/..." imports there, too. Same deal with them: a local import. Leaving them like they are allows the goread code to not live in your $GOPATH, which is fine. If you can link some documentation or other source saying why it's better to use a full path for local app engine packages then I'll merge this.

@maddyblue maddyblue closed this Mar 6, 2014
@akscram
Copy link

akscram commented Mar 18, 2014

I had tried to reproduce the installation of a local environment according the README and got the same problem. What did I do wrong?

@maddyblue
Copy link
Owner

You did nothing wrong, this is supposed to happen. I'm going to fix the install instructions to say that.

@mblakele mblakele mentioned this pull request Dec 15, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants