Install NUnit.Analyzers 4.1.0 and follow all suggested autofixes #203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bartleby2718
commented
Mar 31, 2024
| <PackageVersion Include="Oracle.ManagedDataAccess.Core" Version="3.21.130" Condition="'$(TargetFramework)' == 'netstandard2.1'" /> | ||
| <PackageVersion Include="Oracle.ManagedDataAccess" Version="21.13.0" Condition="'$(TargetFramework)' == 'net462'"/> | ||
| <PackageVersion Include="Oracle.ManagedDataAccess" Version="21.13.0" Condition="'$(TargetFramework)' == 'net462'" /> |
There was a problem hiding this comment.
There was a missing space; fixed by VS 2022's NuGet Package Manager.
| } | ||
|
|
||
| private async ValueTask<int> AddAsync(int a, int b, Thread startingThread, bool expectAsync) | ||
| private static async ValueTask<int> AddAsync(int a, int b, Thread startingThread, bool expectAsync) |
There was a problem hiding this comment.
VS was showing the warning IDE0009, so I added this here and below.
Bartleby2718
commented
Mar 31, 2024
| @@ -110,7 +110,7 @@ public async Task TestAccessingHandleLostTokenWhileKeepaliveActiveDoesNotBlock() | |||
| handle.HandleLostToken.Register(() => { }); | |||
| } | |||
| }); | |||
| Assert.IsTrue(await accessHandleLostTokenTask.TryWaitAsync(TimeSpan.FromSeconds(5))); | |||
| Assert.That(await accessHandleLostTokenTask.TryWaitAsync(TimeSpan.FromSeconds(5)), Is.True); | |||
There was a problem hiding this comment.
Drawing attention here.
Suggested change
| Assert.That(await accessHandleLostTokenTask.TryWaitAsync(TimeSpan.FromSeconds(5)), Is.True); | |
| Assert.That(await accessHandleLostTokenTask.TryWaitAsync(TimeSpan.FromSeconds(5))); |
is also valid and is called the condensed form. For now, I went with the more verbose yet clearer form, but in some cases (e.g. https://github.com/madelson/DistributedLock/pull/203/files#diff-da270224eb19c911add476281ecc4508595b322d7a34c53254e4a82bcaee6e50R24), removing , Is.True can be more readable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #202.
Steps taken:
NUnit.Analyzers4.1.0 through VS 2022's built-in NuGet Package Manager.nunitto the latest version 4.1.0 and noticed that there were some NUnit diagnostics whose severities were not warnings. (I didn't realize there were non-warning diagnostics, but in retrospect, I should've updated.editorconfigto set the severity to warning or above for allClassicAssert-related diagnostics in https://docs.nunit.org/articles/nunit-analyzers/NUnit-Analyzers.html. Also, I didn't realize theCodeGenproject hadNUnitinstalled, so I installedNUnit.Analzyersthere as well.)