Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breaking issues with TCP connections #27

Open
4 tasks
novedevo opened this issue Jun 25, 2021 · 2 comments
Open
4 tasks

Breaking issues with TCP connections #27

novedevo opened this issue Jun 25, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@novedevo
Copy link
Member

novedevo commented Jun 25, 2021 •
edited by gennyble
Loading

  • Needs error handling, not unreachable!() and unwrap()
  • panics when port is not open at that IP
  • infinite hang on, e.g., gmail.com and 1.1.1.1 literal
  • haven't actually gotten a successful connection outta that port. Might be a residential internet problem?
@novedevo novedevo added the bug Something isn't working label Jun 25, 2021
@novedevo
Copy link
Member Author

unreachable!(), for instance. is really just no mx record found, from what I can tell. This should be handled by reverting to the main DNS A/AAAA record, as per RFC.

@gennyble
Copy link
Member

If no MX is found, the client now checks for an A record there. if no A or AAAA is found, we get to unreachable!() again. It's progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@novedevo @gennyble