Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement issue 108 added a verification when deleting a user #111

Merged
merged 2 commits into from
Oct 10, 2023
Merged

Conversation

rabroldan
Copy link
Contributor

Added ehancement to include a verification on issue 108 when deleting a usesr kindly pls review

@madeofpendletonwool
Copy link
Owner

madeofpendletonwool commented Oct 4, 2023

Hi rabroldan! Unfortunatly, this isn't quite there. The application is built using Flet. A GUI library for python. Around the code you'll see numerous snack_bars and alert dialogs. The alert dialogs present an interative box for users and the snack bar presents information to the screen. This application is ran in a docker container and the user accesses the GUI over app or web browser so unfortunately they don't have access to the command line to enter input. I would check out the documentation on Snack Bars and alert dialogs if you aren't familiar. The way this could be done is to present some kind of confirmation after clicking delete user using the same or another alert dialog.

https://flet.dev/docs/controls/alertdialog
https://flet.dev/docs/controls/snackbar

Currently, presenting input to the application simply sends that to the logging of the docker container like below. There's no way to actually confirm that.

wait-pinepods-1 | Are you sure you want to delete user 4? (yes/no): [2023-10-04 12:31:06] [INFO] - uvicorn.error: connection closed

@rabroldan
Copy link
Contributor Author

hi @madeofpendletonwool Can you please review, I now applied a snackbar and alertdialog verification using flet. Thank you

@madeofpendletonwool
Copy link
Owner

This looks great and I can confirm with a quick fix to one of the api calls it works great! Merging it in! Thanks for your work!

@madeofpendletonwool madeofpendletonwool merged commit fe5c5e8 into madeofpendletonwool:main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants