clang-tidy fixes

madeso · Mar 6, 2024 · 1f4bb24 · 1f4bb24
1 parent bbd6c4d
commit 1f4bb24
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 5 deletions.
diff --git a/apps/editor/src/editor/browser.cc b/apps/editor/src/editor/browser.cc
@@ -178,7 +178,10 @@ namespace eu::editor
                             const auto sub_directory = io::DirPath{"./" + item.name};
                             const auto resolved = resolve_relative(sub_directory, current_folder);
                             ASSERTX(resolved.has_value(), sub_directory, current_folder);
-                            current_folder = resolved.value();
+                            if(resolved)
+                            {
+                                current_folder = resolved.value();
+                            }
                         }
                         refresh();
                     }

diff --git a/apps/editor/src/editor/main.cc b/apps/editor/src/editor/main.cc
@@ -1,10 +1,14 @@
 #include "log/log.h"
 
+#include "assert/assert.h"
+
 #include "base/mat4.h"
 #include "base/random.h"
+#include "base/stringutils.h"
+
 #include "io/vfs.h"
+
 #include "core/vfs_imagegenerator.h"
-#include "base/stringutils.h"
 #include "core/stdutils.h"
 #include "core/viewport.h"
 
@@ -510,7 +514,11 @@ struct FileHandlerList
                 )
             )
             {
-                handler->open(windows, path.value());
+                ASSERT(path);
+                if(path)
+                {
+                    handler->open(windows, path.value());
+                }
             }
         }
     }

diff --git a/apps/musikmaskin/src/musikmaskin/main.cc b/apps/musikmaskin/src/musikmaskin/main.cc
@@ -265,7 +265,7 @@ draw_keys
     float spacing
 )
 {
-    ImGuiStyle& style = ImGui::GetStyle();
+    const ImGuiStyle& style = ImGui::GetStyle();
     ImDrawList* draw_list = ImGui::GetWindowDrawList();
 
     float y = start_y;

diff --git a/apps/runner/src/runner/dukregistry.cc b/apps/runner/src/runner/dukregistry.cc
@@ -145,7 +145,7 @@ namespace eu::runner
         }
         else
         {
-            sol::error err = val;
+            const sol::error err = val;
             const auto message = fmt::format("Failed to call create for component {0}({1}): {2}", name, core::ecs::c_comp(comp), err.what());
             LOG_ERROR("{0}", message);
             if(!ctx->has_error)