"fs.service" was added to manage file-system indexing more efficient + fix #21 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mirismaili
force-pushed
the
fs.service
branch
4 times, most recently
from
c52a564
to
aba1832
Compare
…xing more efficient `fs.service` was added to manage file-system indexing more efficient. It also fixes "twice-event-report" problem caused by `git` command (madewithkoji#21). This service (that is a singleton) can cache the result of requests and so improves the performance. It exposes an extra layer on top of `readDirectory` that consumers (`buildConfig.js`, `refresh.js`, and `watch.js` for now) should use (instead of direct access to `readDirectory`). fix madewithkoji#21
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fs.servicewas added to manage file-system indexing more efficient. It also fixes"twice-event-report" problem caused by
gitcommand (#21).This service (that is a singleton) can cache the result of requests and so improves the performance.
It exposes an extra layer on top of
readDirectorythat consumers (buildConfig.js,refresh.js,and
watch.jsfor now) should use (instead of direct access toreadDirectory).