Various fixes for ELYON launcher #31
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
March 5, 2022 11:27
ELYON launcher uses this directly via reflection to change its config file. That approach still won't work, because the class currently has no integration with other components.
According to MSDN, if XmlSerializerFormatAttribute and DataContractFormatAttribute are not defined, the class attribute is used, or failing that DataContractSerializer. This is needed by CefSharp's BrowserProcessResponse class.
This is, apparently, supposed to be done across the board in System.ServiceModel, and is done other places. There's no clear central location to handle this.
|
This introduced test failures: System.ServiceModel was changed and I haven't seen these in other runs, so they're probably caused by the changes. |
|
Manually merged, dropped the System.ServiceModel change for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A set of fixes I made for the ELYON launcher, unfortunately I wasn't able to get it working at the time so I shelved it. I've since learned that it helps Automation which also uses CefSharp so I've cleaned them up for inclusion.