Skip to content

Commit

Permalink
Merge pull request #18 from madflojo/minorstuff
Browse files Browse the repository at this point in the history
Minor changes
  • Loading branch information
madflojo committed Jun 24, 2023
2 parents fafb77c + b791315 commit afcc287
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 10 deletions.
14 changes: 6 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
# Contributing to Tasks

Thank you for your interest in helping develop Tasks. The time, skills, and perspectives you contribute to this project are valued.
Thank you for being so interested in helping develop Tasks. The time, skills, and perspectives you contribute to this project are valued.

# How can I contribute?
## Issues and Proposals

Bugs, Design Proposals, Feature Requests, and Questions are all welcome and can be submitted by creating a [Github Issue](https://github.com/madflojo/tasks/issues/new/choose) using one of the templates provided. Please provide as much detail as you can.
Bugs, Proposals, & Feature Requests are all welcome. To get started, please open an issue via GitHub. Please provide as much detail as possible.

Code contributions are welcome as well! In an effort to keep this project tidy, please:
- Use `go mod` to install and lock dependencies
- Use `gofmt` to format code and tests
- Run `go vet -v ./...` to check for any inadvertent suspicious code
- Write and run unit tests when they make sense using `go test`
## Contributing

Contributions are always appreciated, please try to maintain usage contracts.
4 changes: 2 additions & 2 deletions tasks.go
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ func (schd *Scheduler) Lookup(name string) (*Task, error) {
defer schd.RUnlock()
t, ok := schd.tasks[name]
if ok {
return t, nil
return t.Clone(), nil
}
return t, fmt.Errorf("could not find task within the task list")
}
Expand All @@ -322,7 +322,7 @@ func (schd *Scheduler) Tasks() map[string]*Task {
defer schd.RUnlock()
m := make(map[string]*Task)
for k, v := range schd.tasks {
m[k] = v
m[k] = v.Clone()
}
return m
}
Expand Down

0 comments on commit afcc287

Please sign in to comment.