Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] task err func: add task's id access #11

Closed
wants to merge 1 commit into from

Conversation

matthieujoossen
Copy link

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Small and simple changes (Tech Debt, Doc updates, Adding tests, etc.)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, ensuring GoDoc readability and clarity in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have added tests that ensure my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

If checklist items are unchecked please explain.

@madflojo
Copy link
Owner

Hi @matthieujoossen thanks for opening the pull request, I like the idea of including the taskid but I'd rather not break the function arguments. I'm thinking we could either wrap the errors with a task id or make the task id a variadic argument to make it optional. I'm thinking wrapping the error maybe a bit cleaner.

@madflojo madflojo mentioned this pull request Jun 22, 2023
@madflojo madflojo closed this in #14 Jun 23, 2023
@madflojo
Copy link
Owner

Hi @matthieujoossen, I went another route for this change via #14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants