Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes #18

Merged
merged 3 commits into from
Jun 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 6 additions & 8 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
# Contributing to Tasks

Thank you for your interest in helping develop Tasks. The time, skills, and perspectives you contribute to this project are valued.
Thank you for being so interested in helping develop Tasks. The time, skills, and perspectives you contribute to this project are valued.

# How can I contribute?
## Issues and Proposals

Bugs, Design Proposals, Feature Requests, and Questions are all welcome and can be submitted by creating a [Github Issue](https://github.com/madflojo/tasks/issues/new/choose) using one of the templates provided. Please provide as much detail as you can.
Bugs, Proposals, & Feature Requests are all welcome. To get started, please open an issue via GitHub. Please provide as much detail as possible.

Code contributions are welcome as well! In an effort to keep this project tidy, please:
- Use `go mod` to install and lock dependencies
- Use `gofmt` to format code and tests
- Run `go vet -v ./...` to check for any inadvertent suspicious code
- Write and run unit tests when they make sense using `go test`
## Contributing

Contributions are always appreciated, please try to maintain usage contracts.
4 changes: 2 additions & 2 deletions tasks.go
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,7 @@ func (schd *Scheduler) Lookup(name string) (*Task, error) {
defer schd.RUnlock()
t, ok := schd.tasks[name]
if ok {
return t, nil
return t.Clone(), nil
}
return t, fmt.Errorf("could not find task within the task list")
}
Expand All @@ -322,7 +322,7 @@ func (schd *Scheduler) Tasks() map[string]*Task {
defer schd.RUnlock()
m := make(map[string]*Task)
for k, v := range schd.tasks {
m[k] = v
m[k] = v.Clone()
}
return m
}
Expand Down