Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AddWithID function #5

Merged
merged 3 commits into from
Feb 5, 2022
Merged

Added AddWithID function #5

merged 3 commits into from
Feb 5, 2022

Conversation

snassr
Copy link
Contributor

@snassr snassr commented Feb 4, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, ensuring GoDoc readability and clarity in hard-to-understand areas
  • I have made corresponding changes to documentation
  • I have added tests that ensure my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

If checklist items are unchecked please explain.

tasks.go Outdated Show resolved Hide resolved
tasks.go Outdated Show resolved Hide resolved
@madflojo
Copy link
Owner

madflojo commented Feb 4, 2022

Thanks for the contribution @snassr looks pretty good. I added some suggested edits to adjust some spacing on the example code in the go docs. Aside from that everything looks great.

snassr and others added 2 commits February 4, 2022 14:18
Co-authored-by: Benjamin Cane <madflojo@users.noreply.github.com>
Co-authored-by: Benjamin Cane <madflojo@users.noreply.github.com>
@snassr snassr requested a review from madflojo February 4, 2022 22:24
@madflojo madflojo merged commit 2aca177 into madflojo:main Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants