Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve suspicious env checks #1

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

tspearconquest
Copy link
Contributor

@tspearconquest tspearconquest commented Jun 21, 2022

Signed-off-by: Thomas Spear tspear@conquestcyber.com

* This improves the suspicious env check by running several checks of the env values and performing some basic parsing of the keys and values to look for anything suspicious while avoiding false positives

Signed-off-by: Thomas Spear <tspear@conquestcyber.com>
@madhuakula
Copy link
Owner

Hi @tspearconquest

First of all thanks for trying out this project and big thanks for improving it 🙏

I have checked the PR and it looks great, btw this project initially created with the intention of showcasing the possible research when early days of OPA, Conftest, etc. Now I am going to see how I can improve to use as a full blow checker with customisation of plug-n-play style (as most of the organisations have their own set of policies and rules).

Would love to see if you are interested in working on this to add your valuable inputs, suggestions, feedback and contributions.

Thanks a ton once again 👍

@madhuakula madhuakula merged commit 5e6f4b3 into madhuakula:master Jun 27, 2022
@tspearconquest tspearconquest deleted the env_check_improvements branch June 27, 2022 13:10
@tspearconquest
Copy link
Contributor Author

Would love to see if you are interested in working on this to add your valuable inputs, suggestions, feedback and contributions.

I'm happy to provide feedback and input! I must admit I have a really full workload so I'm not sure if I can commit to contributing code more than this pull request at this time, however later when my workload is lower, I am definitely happy to. Please let me know how can I help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The suspicious environment check has some cases where it can cause false positives
2 participants