Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade execa #142

Closed
abhijithvijayan opened this issue Oct 26, 2019 · 8 comments
Closed

Upgrade execa #142

abhijithvijayan opened this issue Oct 26, 2019 · 8 comments
Labels
enhancement Enhancement to an existing feature help wanted Extra attention is needed

Comments

@abhijithvijayan
Copy link

The package execa has so many updates and deprecated options.

Shouldn't this be updated?
@welcome
Copy link

welcome bot commented Oct 26, 2019

Thanks for opening your first issue here! Be sure to follow the issue template!

@jamesgeorge007
Copy link
Member

Feel free to shoot a PR 👏

@jamesgeorge007
Copy link
Member

It seems this is gonna introduce breaking changes due to the API changes.

@abhijithvijayan
Copy link
Author

abhijithvijayan commented Oct 26, 2019 •
edited

But first, if a list of commands used could be sorted and listed, that would be easier for as to check if deprecated or not.

Update: sure it will have breaking-changes

@abhijithvijayan
Copy link
Author

abhijithvijayan commented Oct 26, 2019 •
edited

execa.syncShell is to be replaced with

execa(command, {shell: true})

@jamesgeorge007 jamesgeorge007 added assigned enhancement Enhancement to an existing feature help wanted Extra attention is needed labels Nov 2, 2019
@abhijithvijayan
Copy link
Author

Is this ready to be worked on?

abhijithvijayan added a commit to abhijithvijayan/mevn-cli that referenced this issue Nov 2, 2019
@abhijithvijayan
feat: (madlabsinc#142) upgrade execa package
4678a6d
@abhijithvijayan abhijithvijayan mentioned this issue Nov 2, 2019
Closed
9 tasks
@abhijithvijayan
Copy link
Author

Feel free to assign this to somebody else.

I may not get time to get back to this.

pksjce pushed a commit to kalcifer/mevn-cli that referenced this issue Mar 8, 2020
fix: madlabsinc#164, madlabsinc#142
d098395 
Description: Use vue-cli-service's --open. Pass port from launch.js . Use port 3002. Update execa to latest. Convert .shell() to option {shell:true}
pksjce pushed a commit to kalcifer/mevn-cli that referenced this issue Mar 8, 2020
fix: madlabsinc#164, madlabsinc#142
d31d904 
Description: Use vue-cli-service's --open. Pass port from launch.js . Use port 3002. Update execa to latest. Convert .shell() to option {shell:true}
@pksjce pksjce mentioned this issue Mar 8, 2020
Closed
pksjce pushed a commit to kalcifer/mevn-cli that referenced this issue Mar 9, 2020
fix: madlabsinc#164, madlabsinc#142
6355682 
Use vue-cli-service's --open. Pass port from launch.js . Use port 3002. Update execa to latest. Convert .shell() to option {shell:true}
@jamesgeorge007
Copy link
Member

Not of higher priorities.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Enhancement to an existing feature help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deps): upgrade execa abhijithvijayan/mevn-cli
2 participants
@jamesgeorge007 @abhijithvijayan