Fix error while deleting .git directory on Windows #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesgeorge007
requested changes
Apr 25, 2019
anto-christo
force-pushed
the
feat/improvements
branch
from
7938722
to
2e5cabe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error thrown while deleting the
.gitdirectory on Windows.The main reason was due to the path. Windows uses
\in it's path and Unix uses/. Hence, have to use thepathmodule to dynamically generate the path based on OS.Secondly, we would like to delete all the contents of
.gitdirectory. Hence, have to usermdircommand with options in place ofdelcommand.