Fix new project not created if a non-empty folder with the same name as boilerplate repo exists. #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as the boilerplate already exists in same directory
|
Thanks for opening this pull request! Please check out our contributing guidelines. |
|
Hurray 🎉 Congrats on your very first contribution 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I came across this issue today. While creating a new project, if a non-empty folder with the same name as the base boilerplate repository name (mevn-boilerplate/mevn-pwa-boilerplate..) exists in the same location, then the new project is not created and the folder with boilerplate name is renamed to the new project name.
This is happening because we are first cloning the boilerplate repo and then renaming it. So, while cloning, it detects that a non-empty folder with the same name already exists and it stops cloning. The renaming is then done on the existing folder.
Fix
This can be fixed by cloning the boilerplate repo directly with the new project name instead of the repo name. This way we eliminate the need for renaming as well.
This can be done by passing the project name as an additional option to git clone command.
Eg:
git clone url project_name