Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: key is optional now issue 54 #56

Closed
wants to merge 5 commits into from
Closed

fix: key is optional now issue 54 #56

wants to merge 5 commits into from

Conversation

sandeepsj
Copy link
Contributor

@sandeepsj sandeepsj commented Dec 12, 2019

Description

Issue 54 .
Fixes # (issue)

  • [ In fetchtask command key is option is made as optional. ] New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@welcome
Copy link

welcome bot commented Dec 12, 2019

Thanks for opening this pull request! Please check out our contributing guidelines.

@ghost
Copy link

ghost commented Dec 12, 2019

There were the following issues with this Pull Request

  • Commit: c0d50a3
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 26fe455
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Dec 13, 2019

There were the following issues with this Pull Request

  • Commit: c0d50a3
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 26fe455
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@ghost
Copy link

ghost commented Dec 13, 2019

There were the following issues with this Pull Request

  • Commit: c0d50a3
    • ✖ message may not be empty
    • ✖ type may not be empty
  • Commit: 26fe455
    • ✖ message may not be empty
    • ✖ type may not be empty

You may need to change the commit messages to comply with the repository contributing guidelines.


🤖 This comment was generated by commitlint[bot]. Please report issues here.

Happy coding!

@sandeepsj sandeepsj changed the title key is optional now issue 54 fix: key is optional now issue 54 Dec 13, 2019
@sandeepsj sandeepsj closed this Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant