Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using source nash directory when inferring nashroot #280

Merged
merged 6 commits into from Jun 21, 2019

Conversation

i4ki
Copy link
Collaborator

@i4ki i4ki commented Jun 16, 2019

Close #272

Signed-off-by: Tiago de Bem <tiago.moura@nginx.com>
@i4ki i4ki requested review from katcipis and vitorarins June 16, 2019 18:43
i4ki added 4 commits June 16, 2019 20:48
Signed-off-by: Tiago de Bem <tiago.moura@nginx.com>
Signed-off-by: Tiago de Bem <tiago.moura@nginx.com>
Signed-off-by: Tiago de Bem <tiago.moura@nginx.com>
Signed-off-by: Tiago de Bem <tiago.moura@nginx.com>
Copy link
Member

@katcipis katcipis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Tiago de Bem <tiago.moura@nginx.com>
@codecov-io
Copy link

codecov-io commented Jun 21, 2019

Codecov Report

Merging #280 into master will increase coverage by 0.06%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #280      +/-   ##
=========================================
+ Coverage   52.84%   52.9%   +0.06%     
=========================================
  Files          35      35              
  Lines        5081    5062      -19     
=========================================
- Hits         2685    2678       -7     
+ Misses       2136    2124      -12     
  Partials      260     260
Impacted Files Coverage Δ
cmd/nash/env.go 78.94% <ø> (-2.88%) ⬇️
tests/cfg.go 57.14% <87.5%> (+17.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c20a1ba...19be9e0. Read the comment docs.

@i4ki i4ki merged commit 2434780 into master Jun 21, 2019
@i4ki i4ki deleted the fix-gopath-mdir branch June 21, 2019 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error when GOPATH contains multiple entries (master)
3 participants